Skip to content

Dotenv dryrun fromuri#4

Merged
AbbyGi merged 12 commits intoNSLS2:mainfrom
AbbyGi:dotenv-dryrun-fromuri
Mar 31, 2026
Merged

Dotenv dryrun fromuri#4
AbbyGi merged 12 commits intoNSLS2:mainfrom
AbbyGi:dotenv-dryrun-fromuri

Conversation

@AbbyGi
Copy link
Copy Markdown
Contributor

@AbbyGi AbbyGi commented Mar 27, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@JunAishima JunAishima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things can be improved here, and reduce unnecessary code and indirect calls.

Copy link
Copy Markdown
Contributor

@JunAishima JunAishima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export_tools.get_scantype() is not referenced anywhere, please remove.

@JunAishima JunAishima added the HOLD FOR MAINT Do not merge until maintenance label Mar 30, 2026
@JunAishima JunAishima marked this pull request as ready for review March 31, 2026 13:44
@JunAishima JunAishima self-requested a review March 31, 2026 17:48
@AbbyGi AbbyGi merged commit 32aff14 into NSLS2:main Mar 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HOLD FOR MAINT Do not merge until maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants